Changeset 8cebc88 in rattail

Timestamp:

08/12/2020 03:10:33 PM (2 years ago)

Author:

Lance Edgar <lance@…>

Branches:

master

Children:

785a54f

Parents:

87f11679

Message:

Fix how we obtain local system title for importers

we just can't go around assuming a handler is always in use

File:

• rattail/importing/importers.py (modified) (4 diffs)

rattail/importing/importers.py

@@ -131 +131 @@
         self._setup(**kwargs)
 
+    def get_local_system_title(self):
+        """
+        Retrieve the system title for the local/target side.
+        """
+        if hasattr(self, 'handler'):
+            return self.handler.local_title
+        return self.local_system_title or "??"
+
     def include_fields(self, *args):
         """
@@ -297 +305 @@
         try:
             self.progress_loop(import_, data, message="{}ing {} data to {}".format(
-                self.direction.capitalize(), self.model_name, self.handler.local_title))
+                self.direction.capitalize(), self.model_name, self.get_local_system_title()))
         except ImportLimitReached:
             pass
@@ -470 +478 @@
         self.progress_loop(cache, objects,
                            message="Reading {} data from {}".format(
-                               self.model_name, self.handler.local_title))
+                               self.model_name, self.get_local_system_title()))
         return cached
 
@@ -477 +485 @@
         Must return a message to be used for progress when fetching "local" data.
         """
-        return "Reading {} data from {}".format(self.model_name, self.handler.local_title)
+        return "Reading {} data from {}".format(self.model_name, self.get_local_system_title())
 
     def get_cache_key(self, obj, normal):