Changeset f34703e in rattail

Timestamp:

07/22/2022 12:38:16 PM (7 months ago)

Author:

Lance Edgar <lance@…>

Branches:

master

Children:

032dcc3

Parents:

dfadd3f

Message:

Add flags for auto-creating brand in product importers

if brands are tracked with foreign system key, then auto-create is
probably not suitable since new brand won't get the key

Location:

rattail

Files:

• datasync/daemon.py (modified) (1 diff)
• importing/model.py (modified) (4 diffs)

rattail/datasync/daemon.py

@@ -653 +653 @@
                 return False
 
+            else: # more attempts to be made, but log error for debug
+                log.debug("attempt #%s failed calling `consumer.process_changes()`",
+                          attempts, exc_info=True)
+
             # if this exception is not the first, and is of a different type
             # than seen previously, do *not* continue to retry

rattail/importing/model.py

@@ -1716 +1716 @@
     def set_config_flags(self):
 
+        # set to True in order to auto-create record for "unknown" brand
+        self.auto_create_unknown_brand = self.config.getbool(
+            'rattail.importing', 'products.auto_create_unknown_brand',
+            default=False)
+
         # set to True in order to auto-create record for "unknown" category
         self.auto_create_unknown_category = self.config.getbool(
@@ -1725 +1730 @@
             'rattail.importing', 'products.auto_create_unknown_report_code',
             default=False)
+
+        # set to False in order to log debug instead of warning for "unknown" brand
+        self.warn_for_unknown_brand = self.config.getbool(
+            'rattail.importing', 'products.warn_for_unknown_brand',
+            default=True)
 
         # set to False in order to log debug instead of warning for "unknown" category
@@ -1967 +1977 @@
     def update_object(self, product, data, local_data=None):
         product = super(ProductImporter, self).update_object(product, data, local_data)
+        model = self.model
 
         if 'brand_name' in self.fields:
@@ -1972 +1983 @@
             if name:
                 brand = self.get_brand(name)
-                if not brand:
+                if brand:
+                    product.brand = brand
+                elif self.auto_create_unknown_brand:
                     brand = model.Brand()
                     brand.name = name
                     self.session.add(brand)
                     if hasattr(self, 'brands'):
-                        self.brands[brand.name] = brand
-                product.brand = brand
+                        self.brands[name] = brand
+                    product.brand = brand
+                else:
+                    logger = log.warning if self.warn_for_unknown_brand else log.debug
+                    logger("unknown brand for product %s: %s", product.uuid, name)
+                    if product.brand:
+                        product.brand = None
             elif product.brand:
                 product.brand = None