Changeset f85e800 in rattail

Timestamp:

07/29/2020 12:09:53 AM (3 years ago)

Author:

Lance Edgar <lance@…>

Branches:

master

Children:

e16175f

Parents:

11a1c8c

Message:

Be smarter about deleting rows, when deleting batch

this seems to be more efficient than the previous attempt...

File:

• rattail/batch/handlers.py (modified) (2 diffs)

rattail/batch/handlers.py

@@ -733 +733 @@
 
             def delete(row, i):
-                batch.data_rows.remove(row)
                 session.delete(row)
                 if i % 200 == 0:
@@ -740 +739 @@
             self.progress_loop(delete, batch.data_rows, progress,
                                message="Deleting rows from batch")
+
+            # even though we just deleted all rows, we must also "remove" all
+            # rows explicitly from the batch; otherwise when the batch itself
+            # is deleted, SQLAlchemy may complain about an unexpected number of
+            # rows being deleted
+            del batch.data_rows[:]
 
     def setup_clone(self, oldbatch, progress=None):